wgpu icon indicating copy to clipboard operation
wgpu copied to clipboard

`wgpu_types::Features::SHADER_INT64_ATOMIC_ALL_OPS` should also request `shader_shared_int64_atomics`

Open jimblandy opened this issue 1 month ago • 0 comments

I missed this reviewing #5383, but in PhysicalDeviceFeatures::from_extensions_and_requested_features in wgpu-hal/src/vulkan/adapter.rs, when we populate shader_atomic_int64, we should set both shader_buffer_int64_atomics and shader_shared_int64_atomics, since we require both in PhysicalDeviceFeatures::to_wgpu.

cc @atlv24 @teoxoy

jimblandy avatar Jun 09 '24 00:06 jimblandy