wgpu icon indicating copy to clipboard operation
wgpu copied to clipboard

use smallvec instead of inplace_it

Open mockersf opened this issue 1 year ago • 2 comments

Checklist

  • [x] Run cargo clippy.
  • [x] Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • [x] Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description Remove inplace_it to use smallvec instead. While inlace_it tries to be clever with the size of the array used, I just set it to 32 in smallvec On latest nightly, inplace_it fails to compile. This will probably be fixed on Rust (https://github.com/rust-lang/rust/pull/99288) or inplace_it (https://github.com/NotIntMan/inplace_it/pull/11), but inplace_it hasn't been updated in a while.

Testing This is Vulkan only change and I don't have a Vulkan capable machine, so not tested a lot...

mockersf avatar Jul 15 '22 20:07 mockersf

Could we use tinyvec instead and reduce the unsafe code surface?

notgull avatar Jul 16 '22 03:07 notgull

I went with smallvec as it's already in tree

mockersf avatar Jul 16 '22 07:07 mockersf