wgpu icon indicating copy to clipboard operation
wgpu copied to clipboard

Push constants in render bundles are half-implemented

Open jimblandy opened this issue 3 years ago • 3 comments
trafficstars

RenderBundleEncoder::finish propagates SetPushConstant commands from the encoder to the final RenderBundle, but the bundle's BasePass's push_constant_data vector is always empty.

jimblandy avatar May 21 '22 21:05 jimblandy

Note that push constants are not yet specified in WebGPU: gpuweb/gpuweb#75

jimblandy avatar May 21 '22 21:05 jimblandy

Coming up on the 2-year anniversary for this issue, are there any current plans to support this? If nothing else, it would probably be good to catch any use of push constants in RenderBundleEncoder, rather than crashing at (potentially much later) point in time. Potentially by removing the set_push_constants method altogether until this is actually implemented. :-)

simonask avatar May 07 '24 09:05 simonask

I don't think this is on anybody's radar right now, so we'd accept a PR either fixing it, or removing it.

cwfitzgerald avatar May 07 '24 14:05 cwfitzgerald