rspirv icon indicating copy to clipboard operation
rspirv copied to clipboard

Regenerate on `sdk-1.4.335.0`

Open MarijnS95 opened this issue 7 months ago • 4 comments

https://github.com/KhronosGroup/SPIRV-Headers/releases/tag/vulkan-sdk-1.4.328.1

MarijnS95 avatar Jun 20 '25 09:06 MarijnS95

LGTM, but who is generally reviewing rspirv these days?

kvark avatar Sep 24 '25 04:09 kvark

@kvark I don't know unfortunately 😅 - I've mostly been performing upgrades and fixing random user reports while I didn't really have a use for this crate myself, but it still seems gfx-rs is using it in naga? @msiglreith used to be reviewing my PRs in the past at least :)

MarijnS95 avatar Sep 24 '25 08:09 MarijnS95

Looking at the diff myself, I've yet to add some new OpTypes to the grammar so that we don't end up with an error like #266 later, will do so soon.

MarijnS95 avatar Sep 24 '25 08:09 MarijnS95

It always surprised me that we had to manually add these (and have a lot of bugs like #266 as a result), even though they can be very trivially generated: #269

MarijnS95 avatar Sep 29 '25 10:09 MarijnS95