mptsd icon indicating copy to clipboard operation
mptsd copied to clipboard

Published 20 hours ago • verified publisher icon gfto

Issues with "-B" != 38

Open lars18th opened this issue 6 years ago • 7 comments

Hi,

When using the parameter "-B" for streaming with different bandwith than the default one (38Mbps), after some time of starting the execution I see error messages and the output stream corrupts:

Jun 15 00:39:18 host ux-mptsd: INPUT : [ch1         ] Disable input, buffer is full. fd: 4 src: udp://239.0.0.1:12345

I feel the INPUT buffer goes full because some timing in the code doesn't work for less than the stock 38Mbps. Any idea about how to fix it?

Thank you!

lars18th avatar Jun 14 '18 22:06 lars18th

Hi,

I feel this issue is related to inputs with padding (NULL packets). I resolved it with this PR #22 .

I hope you merge it! :smile:

lars18th avatar Jun 19 '18 16:06 lars18th

Hi,

I found the bug! This PR #23 solves the trouble. Now you can use any output bitrate without troubles! :wink:

lars18th avatar Jun 27 '18 11:06 lars18th

Hi,

The PR #27 solves this problem entirely! :smile: I hope it be merged soon. :crossed_fingers:

lars18th avatar Jul 03 '18 12:07 lars18th

Hi,

I found another severe bug regarding this issue. I fixed it with this PR https://github.com/gfto/mptsd/pull/28

I hope soon you can merge it!

lars18th avatar Jul 09 '18 17:07 lars18th

Hi lars18th, does #28 has the #27 fix included ?

salvaaod avatar Sep 08 '20 08:09 salvaaod

Hi lars18th, does #28 has the #27 fix included ?

No. They (#28 and #27) are independent patches. So you need to apply all!

Regards.

lars18th avatar Sep 08 '20 11:09 lars18th

Hi lars18th, does #28 has the #27 fix included ?

No. They (#28 and #27) are independent patches. So you need to apply all!

Regards.

Thanks, and I understand that #27 supersedes #23 and #22 or should I apply all to get rid of the null padding with low bitrates ?

salvaaod avatar Sep 08 '20 16:09 salvaaod