Giulia Stocco
Giulia Stocco
We are now also distributing devskim as a dotnet global tool. That may help in the meantime with a single line install (as long as you have .net core 3.1...
I don't think we can support this without some refactoring of the extension. Currently we are grabbing files off the disc.
To support this we need to change this call https://github.com/microsoft/DevSkim/blob/7e200c4feed21cf9671b707796fbae5e67c3d349/DevSkim-VSCode-Plugin/server/src/devskimCLI.ts#L326 To use this API instead: https://github.com/microsoft/vscode/blob/dc8bd9cd7e5231745549ac6218266c63271f48cd/src/vs/vscode.d.ts#L7210
The code is now working (when the files get placed in the right location). Remaining issue is getting the build to work properly. Hoping to wrap this up by tomorrow.
Known issues: ~The pattern for the fix is ignored and instead the match is replaced with the replacement text. Instead it looks like the match from the finding should be...
@daalcant for signing this vsix should we sign the .NET dlls then embed them or just present the whole vsix to be signed?
The extension currently behaves differently in VS 2019 and 2022. Debugging the 2022 version is *very* slow, while the 2019 version is tolerable. In this PR in both versions if...
Reverted to a draft. Am going to take a different approach to create a single Language Server written in C# that leverages the DevSkim library and use that for both...
Reimplementing in a different branch.
What version and format of devskim are you using? I recently made a change to the C# implementation that should have prevented this from showing up in plaintext (.txt) files....