cinnamon-pomodoro icon indicating copy to clipboard operation
cinnamon-pomodoro copied to clipboard

Changed numerical values from scale to spinbutton to fix issue #67

Open benoitv-code opened this issue 7 years ago • 3 comments

Fixes #67:

In newer Cinnamon updates, the scale component is not displaying numbers anymore, which makes it hard to pick the desired number of minutes we want for a Pomodoro session for example.

This change replaces all "scale" components by "spinbutton" components for selecting specific numbers (minutes or number of pomodori in a session).

Tested on Cinnamon 3.2.7, not tested on previous versions (if someone can test for me it would be great).

Settings panel screenshot

benoitv-code avatar Jul 13 '17 15:07 benoitv-code

Note: Numbers on sliders are back on Cinnamon 3.4.4 (Linux Mint 18.2 released on 2017-07-02), but I feel spinbuttons make more sense to select minutes / numbers of pomodori, so I would still recommend going forward with this pull request.

Screenshot - Cinnamon 3.4.4

benoitv-code avatar Jul 13 '17 16:07 benoitv-code

@kunnix The problem with using spin buttons is it doesn't work in mint 17 which is still a LTS release. (cinnamon 2.8).

gfreeau avatar Sep 17 '17 11:09 gfreeau

Ok, keeping this commit here if things are diverging too much and you want to create 2 branches at some point (mint17 / master).

benoitv-code avatar Sep 18 '17 18:09 benoitv-code