jquery.tocify.js icon indicating copy to clipboard operation
jquery.tocify.js copied to clipboard

Published 20 hours ago • verified publisher icon gfranko

History not working with showAndHide to false

Open avandecreme opened this issue 10 years ago • 3 comments

If showAndHide is set to false and one use a link with an anchor (for example http://gregfranko.com/jquery.tocify.js/#OptionsAPI ) the scrolling won't happen.

There is a specific test about it in the code: https://github.com/gfranko/jquery.tocify.js/blob/master/src/javascripts/jquery.tocify.js#L322-L327 However I can't think of any case where this test is necessary.

Removing the condition fixes the problem.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

avandecreme avatar May 07 '14 21:05 avandecreme

I don't remember why I did that either. I think it would be safe to remove the condition. Would you mind sending a PR to the dev branch to fix this?

gfranko avatar May 08 '14 00:05 gfranko

PR submitted :)

avandecreme avatar May 08 '14 13:05 avandecreme

Sorry for the "me too" but I must say this is exquisite timing - thanks for both tocify and for this PR!

aufflick avatar May 16 '14 11:05 aufflick