Max Gordon

Results 56 comments of Max Gordon
trafficstars

Hello again, there still seems to be issues with the package. The offset affects much more than I at first thought. See below code and errors: ``` S rm(list=ls()) test_df

In 3.0 combining plots is much easier and less error prone. You have also more control over the text style. The graph width should also hopefully work better.

Fixed in version 3.0

Unfortunately I don't see how this would work. In 3.0 all the plotting is moved into the final stage allowing a very flexible handling of staged object manipulation etc.

Solved in 3.0

I found an additional related annoyance, the swagger editor used to set parameters to `hello_world?param1=&param2=value`. I'm not sure if the `param1=` should be an acceptable query spec but it behaves...

The Travis failing is expected as it includes the test "standard controllers should execute with default names" that relates to issue #45

Thank you for this suggestion, shouldn't be that hard to add but unfortunately I lack the required time at the moment. I would love to merge a PR for this...

Sorry for not getting to this earlier, the line.margin seems to be causing issues in the fix. Could you check that the other lineheight works as expected?

I haven't published it yet - you need to use `devtools::install_github("gforge/forestplot", branch = "develop")`