flake8-builtins icon indicating copy to clipboard operation
flake8-builtins copied to clipboard

Add flake-job to CI

Open Bengt opened this issue 4 years ago • 2 comments

To test the code against the latest released version of flake-builtins and demonstrate its usage.

Bengt avatar Jan 16 '20 19:01 Bengt

@Bengt thanks for taking the time to create the issue :sparkles:

Would you mind to explain a bit more what you mean? :thinking: you want another job on the travis CI matrix so that it runs flake8-builitins against this repo? :thinking:

While that would be a good idea, I miss the point of the demonstrate its usage part.

gforcada avatar Jan 17 '20 08:01 gforcada

Hi, @gforcada!

Thanks for thinking about this.

Yes, I mean checking this repo against itself.

On the one hand this would assure that the code quality of this repo reaches a certain level. On the other hand this demonstrate the applicability of the package in a real software project. People who want to follow this example could copy your Travis matrix definition to theirs in the certainty that the commands work in a realistic environment. So that would be a good starting point.

Bengt avatar Jan 17 '20 15:01 Bengt

With #85 I think we are doing enough QA on the code, if you still think we should do more, please re-open the issue 😄

gforcada avatar Oct 08 '22 14:10 gforcada

Hi, @gforcada! I am happy to see that you picked up GitHub actions for this project. As far as I can see, you are not "eating your own dog food" by using your own linter, though. The workflow includes flake8, but without flake8-builtins:

https://github.com/gforcada/flake8-builtins/blob/master/.github/workflows/testing.yml#L50

Bengt avatar Oct 09 '22 21:10 Bengt