Günther Foidl
Günther Foidl
ATM there are build errors, as the public API changes, but there's no entry for that change. So please follow along [How to use Microsoft.CodeAnalysis.PublicApiAnalyzers](https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) to fix the build erros....
> perf looks about the same (between span and addref), so I'd pick whichever results in more readable code. Further: when the aim is to remove _unsafe_ code, we shouldn't...
@mgravell I'm in ❤️ with unsafe, hacks, whatever gives perf also, but from a .NET-PoV the JIT should be teached to avoid / elide these checks, so that the whole...
> This is more efficient: Even better is a comparison with 0, so `>= 0`, as the cpu can fuse the comparison and the jump to only one instruction actually...
> I fixed the CI scripts in #592 btw Should that change be separated into a own PR to fix CI? Otherwise every PR has to re-do the same until...
Found some more allocation that can be quite easily avoided. ``` | Method | Mean | Error | StdDev | Gen0 | Allocated | |-------------------- |------------:|----------:|----------:|-------:|----------:| | CreateQRCode | 240.0...
As written in https://github.com/codebude/QRCoder/issues/605#issuecomment-3342962313 I'd like that the repo here continues to live, and don't be archived, so please merge the PR as it brings goodness to your baby QRCoder.
For some background see [string vs. String is not a style debate](https://blog.paranoidcoding.org/2019/04/08/string-vs-String-is-not-about-style.html). Does your concern belong to an url in the docs? If so, can you please point to that...
IMO the docs are correct, as that's a method of `System.String` type which is unambiguous. Similar to other members of that type. In your user code due to the `using...