gfgtdf

The `load_unit_type()` function its implemented /used so am i right to assume that this is not finished yet? On the ui: Imo next/previous pagers like the one in the attack...

I can reproduce this one on linx aswell

> but I can't replicate this particular issue (side bar not in current language selection). Its not about sidebar, its only about alignment strings

Does anyone know what the issue was? Language changing during the lifetime of a t_string object is something that t_string _should_ be able to handle, that's why it has the...

I don't think the separation between metadata and the ability is that clear, usually i'd say the type is also part of the ability, also we don't have such separation...

When looking a at this code im a bit worried that multiple uses of [unit_overlay] and [remove_unit_overlay] clutter a units wml with useless objects (that cancel each other out, but...

> I don't think it makes sense to mix overlays into (UN)MAKE_HERO. ?, Adding the heo overlay is exactly what MAKE_HERO currently does.

> Adding the hero overlay, yes. Other overlays shouldn't be mixed in with that. I never talked about other overlays, i'm just talking about the implementation of (UN)MAKE_HERO.

i actualy don't really rememerb the rationale for my last commit > I don't understand why it makes sense to have a default id with `[unit_overlay]` but not with `[remove_unit_overlay]`....

hmm it would be interesting to know whether this already works. This code https://github.com/wesnoth/wesnoth/blob/e506c2a1ffecb18cc545ed1759ad647c9ae29e46/src/saved_game.cpp#L343 makes it look like it does,