gfgtdf

Results 169 comments of gfgtdf

> Is having Peasant/Woodsman/Ruffian in the pool necessary? I think players complain more if they get them instead of not. My personaly expereince from observing WC2 games is not that...

Fixed the epic trait in https://github.com/wesnoth/wesnoth/commit/f7140b2e448b2760b6770ecdd5e0d1673fc1d382 > Always rest heals training might not work (not sure, needs investigation) Okay this is 1.16 only and was fixed in https://github.com/wesnoth/wesnoth/commit/0ca5a97d1fddfe02c409b9443f8811dbac1fc9af (note the...

> I got the bug on the latest build of 1.17.x last night. Could you maybe give a savefile where this happens?

The names of the (auto) saves are also not optimal in my opinion: ![image](https://github.com/wesnoth/wesnoth/assets/4893136/f0fae82d-0b3b-4490-b236-37c8c28d6f55)

In case someone wants to work on it: The problem is probably that when populating the modlist in https://github.com/wesnoth/wesnoth/blob/8977c1e60d09a9e852753bbf471d76be0cac62cf/src/game_initialization/create_engine.cpp#L783 The code removes dunblicates But when the other list of populated...

Of course this is not an ideal solution, one could ask why do we need 2 lists (that can be out of sync) in the first place, and if we...

After seeing the actual usecases, (which is an addon that includes the same file multiple times via macro inclusion ) i think it would maybe be better if we just...

> Is it with filesystem manipulation (e.g. removing add-ons), or without? I easily get it if I mangle with addons, but the issue always goes away if I clear the...

Even if it would be that simple, we are already in string freeze currently

So this randomyl happend to me on the 1.16 multiplayer server, so i took a look at what the client actually receives: ``` [game] active_mods = plan_unit_advance,WoL_mod_enable_armageddon,WoL_mod_enable_dwarven_runesmith,WoL_mod_enable_dwarven_arcanister,WoL_mod_enable_Nightblade,WoL_mod_enable_dune_paragon,WoL_mod_enable_troll_shaman,WoL_mod_enable_death_knight,WoL_mod_enable_ancient_lich,Rav_XP_Mod,WoL_mod_enable_elvish_lord difficulty_define = EASY...