bm3d icon indicating copy to clipboard operation
bm3d copied to clipboard

Values of N passed to sub_divide seem wrong

Open ajeb78 opened this issue 2 years ago • 0 comments

In bm3d.cpp, lines 272, 304, 307 and 341 seem to do the following:

  • chop the image into pieces with border 2 * nWien
  • reassemble the image based on subimages with borders 2 * nHard
  • chop the image into subimages with borders 2 * nHard
  • reassemble the image based on subimages with borders 2 * nWien

Shouldn't the values of N for chopping the image up and reassembling it be the same? In practice it doesn't matter because nWien and nHard are both defined as the same value, but if one value was changed it seems the result would not be good. I think the parameters on those lines should respectively be 2 * nHard, 2 * nHard, 2 * nWien, 2 * nWien.

ajeb78 avatar Sep 07 '22 19:09 ajeb78