Gil comments

Results 78 comments of

Gil

trafficstars

Write a utility function to make a shallow copy of an SGObject

yup, and then find places where you can use it. You could also use the `make_clone` function instead, but it would be the same

Write a utility function to make a shallow copy of an SGObject

https://github.com/shogun-toolbox/shogun/blob/78cfc5f4ef6daf196819f900234be7d5455bc3a1/src/shogun/multiclass/tree/RelaxedTree.cpp#L299

Write a utility function to make a shallow copy of an SGObject

@karlnapf are those the flags you would expect a shallow copy to use?

Add feature importance calculation to Random Forest and C4.5

@javiermaldonadoc i think this is currently in progress in #4899

Add feature importance calculation to Random Forest and C4.5

feature added in #4899

Add feature importance calculation to Random Forest and C4.5

C4.5 is being added in #4918

Replace Math::fequals with new utility function

@karlnapf @vigsterkr I am assuming we should also remove `fequals_epsilon` in env in favour of `std::numeric_limits::epsilon`?

Replace Math::fequals with new utility function

Hi, sure, those can be moved as well. Easiest is to start a PR and can take it from there.

Enable models to emit lambda functions.

You mean this would be like a promise that can the be computed asynchronously? Could you give an example of a lambda you would want to pass please? From the...

Enable models to emit lambda functions.

> We wouldnt want to store the lambda. The class just offers the lambda to the observer, which can decide to call it (and store the information), or not. It...