Gil

Results 78 comments of Gil

Yes, I agree. I think that at least all integer types should be implicitly converted between them using the safe conversion helpers we already have. The same for floating points....

Hmmm, I guess this is why the random forest meta example sometimes fails locally... Have you tried to run it in gdb yet?

From what I can tell is that `m_root` contains a `nullptr`. It seems like that is the default value in the default constructor. And you can see that it says...

Hmm I see, it needs the template parameter. @vigsterkr I guess we need to replace `TreeMachineNode` with non templated version?

@LiuYuHui sorry for the delays, I was meant to do this a while ago. I rebased your branch now and it should be good to merge soon. Feel free to...

This should be a class. No problem, have a look at other classes that inherit from Transform in https://github.com/shogun-toolbox/shogun/tree/develop/src/shogun/preprocessor, it should help get you started :)

Hmm ok, so I think that either we add a `#ifdef` block checking the Eigen version around the code that is causing issues or we don't allow users to compile...

@eadwu do you want to update CMakeLists.txt to throw an error if the user version is above `3.3.7`? Just grep `FIND_PACKAGE(Eigen3` and you'll see where you need to make the...

> So in some sense, these kernel should do a lazy precompute of the whole pairwise distance matrix, and then the compute calls just query that (with an iterator for...