Gianni Chiappetta

Results 107 comments of Gianni Chiappetta

according to the GTM documentation the script tag needs to be a direct child of the body (god know's why—ugh) however that's not really possible with most react apps

i fixed it by not including the `` in `render()` and simply doing the `eval` in `componentDidMount()`

e.g.: ``` jsx type DefaultProps = { additionalEvents: Object, dataLayerName: string, scriptId: string }; type Props = DefaultProps & { gtmId: string }; class GoogleTagManager extends React.Component { static defaultProps:...

@shri3k it wouldn't be isomorphic then

cc: @tyler-dodge in case there is additional context that might be useful

thanks for the context @tyler-dodge. this may also be of interest to @d12frosted for https://github.com/d12frosted/homebrew-emacs-plus

i believe [`Cocktail.Validation.Day.next_time/3`](https://github.com/peek-travel/cocktail/blob/80b7c9372e30d97ca6bee3f036fc0d9cf8b81ffc/lib/cocktail/validation/day.ex#L17-L23) is improperly returning change status: ```elixir validation = %Cocktail.Validation.Day{days: [1, 3, 5]} timezone = "America/Toronto" start_time = DateTime.new!(~D[2023-01-01], ~T[00:00:00], timezone) time1 = DateTime.new!(~D[2024-03-06], ~T[00:00:00], timezone) time2 =...

i was able to find the culprit, it's [`Cocktail.Util.shift_time/2`](https://github.com/peek-travel/cocktail/blob/80b7c9372e30d97ca6bee3f036fc0d9cf8b81ffc/lib/cocktail/util.ex#L19-L24): ```elixir iex> time = DateTime.new!(~D[2024-03-10], ~T[00:00:00], timezone) #DateTime iex> Cocktail.Util.shift_time(time, days: 1) #DateTime iex> Timex.shift(time, days: 1) #DateTime ``` this is...

@Matsa59 ahh, it seems to be the time. i was testing with `00:00:00` but it fails in your scenario with `02:00:00`