themes icon indicating copy to clipboard operation
themes copied to clipboard

update-all-themes.yml workflow failing due to problematic submodules

Open hahwul opened this issue 2 months ago • 3 comments

Discovered that the Update all themes (update-all-themes.yml) workflow is currently failing. Likely caused by issues in submodules — need to handle problematic submodules properly.

https://github.com/getzola/themes/actions/runs/18831349654

Image

hahwul avatar Oct 27 '25 14:10 hahwul

ah yes i have just noticed that as well. Looks like some cleaning/update is needed

Keats avatar Oct 28 '25 08:10 Keats

@Keats Yeah, you're right! Proper handling is definitely needed.

Just my personal opinion, but it would be even better if the workflow could handle these cases in the future. (For example, skip problematic submodules and automatically create a GitHub issue)

hahwul avatar Oct 28 '25 12:10 hahwul

Indeed just not anywhere close to high priority, there has been like 2-3 such issues in a few years and the resolution takes 2min so not really worth improving. I should just get notified in case of CI failures

Keats avatar Oct 28 '25 12:10 Keats