hyde icon indicating copy to clipboard operation
hyde copied to clipboard

Feature: `hyde_links` relative from `base_url`

Open homersimpsons opened this issue 1 year ago • 2 comments

Currently, the hyde_links config option is used directly in the template:

https://github.com/getzola/hyde/blob/e6df4068d44fd0067ab956fd387802d79e36f824/templates/index.html#L43

This is somewhat inconvenient when the site is not hosted at the root of the domain (for instance on github pages).

The 2 inconvenient I can see are:

  • Differences between local site and hosted version making it harder to tests changes
  • Impossibility to have a GitHub Repository template that is ready to use

Here are the options I can see of for the current behavior of the list:

  • uses a fully-qualified link: https://...com/my/page => has to update everything on domain change
  • uses a relative link: my/page => breaks on most pages
  • uses a root-relative link: /my/page => works well but not suitable if the hosing is not on the root and changes

I think it would be a good addition if it could be prefixed with the base_url or if there was a syntax to use base_url in the config.toml.

Of course absolute links should still be available.

homersimpsons avatar May 29 '23 15:05 homersimpsons

We can maybe just use get_url ?

Keats avatar May 31 '23 07:05 Keats

I just tested get_url and it looks like it does not handle external links.

homersimpsons avatar Jun 02 '23 12:06 homersimpsons