umbrel icon indicating copy to clipboard operation
umbrel copied to clipboard

Fix user configuration variables being overwritten by previous environment

Open louneskmt opened this issue 4 years ago • 5 comments
trafficstars

Currently, previous environment overwrites new user configuration. https://github.com/getumbrel/umbrel/blob/a423d96e4596b47dc8f5584c6620597a3026bf19/scripts/configure#L100-L102

This can be a problem, as after the first run it is not possible to change user variables like NGINX_PORT.

This PR fixes this issue.

Related : f5a4b8c, https://github.com/getumbrel/umbrel/pull/501#discussion_r584136108

louneskmt avatar Apr 13 '21 14:04 louneskmt

@louneskmt with 0.3.10 its still the same :/

phenomeus avatar May 04 '21 10:05 phenomeus

Yeah that's normal @phenomeus, this PR hasn't been merged yet.

louneskmt avatar May 04 '21 10:05 louneskmt

ok i will try your commit on my machine, fed up with this and using with tor…

phenomeus avatar May 04 '21 11:05 phenomeus

i inserted your commit line by line, stoped, reconfigured, started… same issue: with tor I see every detail, with ip:8000 I can login but see nothing, no chain, no sync status etc

phenomeus avatar May 04 '21 11:05 phenomeus

@louneskmt is there maybe an ETA for this fix?

phenomeus avatar Jun 07 '21 06:06 phenomeus

Thank you for the PR, @louneskmt! With the launch of umbrelOS 1.0, we've introduced extensive changes to both the source code and the system's architecture. As part of this transition, we're reviewing and closing PRs and issues that might no longer be applicable to the new version. So I'll be closing this PR for now. Thanks again!

mayankchhabra avatar Mar 19 '24 10:03 mayankchhabra