umbrel icon indicating copy to clipboard operation
umbrel copied to clipboard

changed method of pulling hostname to be more universal

Open ClayShoaf opened this issue 3 years ago • 2 comments

I was getting errors when trying to install/run umbrel on an Arch system. It appears that hostname is an Ubuntu-specific command (or at least it doesn't exist in Arch). This should allow Umbrel to be compatible with more Linux systems, as long as they have all of the dependencies installed.

ClayShoaf avatar Apr 03 '22 01:04 ClayShoaf

Thanks for the PR! I just took a look at the hierarchy to determine the hostname (as there is also /etc/hostname) and it looks like /proc/sys/kernel/hostname is most ideal.

Would you mind also patching up:

  • https://github.com/getumbrel/umbrel/blob/master/scripts/app#L109
  • https://github.com/getumbrel/umbrel/blob/master/scripts/update/01-run.sh#L165

nevets963 avatar Apr 03 '22 20:04 nevets963

Alright, I think I did that right. Still figuring out the github interface.

When I grepped, I should have left off the trailing parenthesis instead of doing grep -irI '$(hostname)'. That should be all of them now.

ClayShoaf avatar Apr 04 '22 16:04 ClayShoaf

Ah crud. I didn't realize I still had this open when I deleted my repo.

ClayShoaf avatar Apr 11 '23 05:04 ClayShoaf