umbrel icon indicating copy to clipboard operation
umbrel copied to clipboard

[WIP] JMG (JoinMarket GUI)

Open manasgandy opened this issue 3 years ago • 1 comments
trafficstars

App Submission

App name

JMG

Version

0.4.1

One line description of the app

(max 50 characters)

Web-based GUI for JoinMarket

Summary of the app

(50 to 200 words)

This app is a package of JoinMarket and a web-based user-interface for it. JoinMarket is an open-source tool to execute peer-to-peer conjoin transactions without a central coordinator. It involves two parties: maker and taker. Takers pay a fee to makers to collaborate via IRC messaging to form a conjoin transaction and broadcast it to the Bitcoin mempool.

Developer name

Manas Gandy and JoinMarket team

Developer website

https://github.com/manasgandy

Source code link

(Link to your app's source code repository.)

https://github.com/manasgandy/joinmarket-gui

Support link

(Link to your Telegram support channel, GitHub issues/discussions, support portal, or any other place where users could contact you for support.)

...

Requires

  • [x] Bitcoin Core
  • [ ] Electrum server
  • [ ] LND

256x256 SVG icon

(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.)

https://svgshare.com/i/cuW.svg

Gallery images

(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.)

...

I have tested my app on:

manasgandy avatar Dec 17 '21 17:12 manasgandy

Hey @manasgandy thanks for submitting this, can't wait to ship JM on Umbrel!

I had a play with your fork trying to get JM working, I couldn't get it running with any of the existing JM images on Docker Hub. I think you might need to create a new Docker container wrapping JM for this. Since it looks like the setup process of JM is fairly manual involving a few commands, you'd probably need to wrap it with a script that automates the initialisation process of JM.

It looks like the lncm/joinmarket image has attempted this but I wasn't able to get it working (ping @nolim1t). We also pass $APP_SEED to apps which is a hex string encoding determinsitic entropy from the user's main Umbrel seed. If your JM container is able to seed its wallet from this it would mean users JM funds would be backed up with their Umbrel seed and if they uninstalled your app and re-installed later it would derive the same wallet and recover all funds.

lukechilds avatar Jan 31 '22 12:01 lukechilds

Hey @manasgandy! With Umbrel 0.5, we moved the all the Umbrel apps to their own dedicated repository — getumbrel/umbrel-apps. With this change, new apps (and app updates) go live in the Umbrel App Store in realtime as soon as PRs are merged.

So feel free to open a new PR on that repo if you're interested in shipping JMG. Closing this PR for now. Cheers! :)

mayankchhabra avatar Sep 22 '22 20:09 mayankchhabra