umbrel icon indicating copy to clipboard operation
umbrel copied to clipboard

Published 20 hours ago • verified publisher icon getumbrel

added option for a domain

Open SimonHaas opened this issue 4 years ago • 1 comments

The only way I found to run umbrel with a domain was to edit the start script and put your custom domain in the DEVICE_HOSTS variable to avoid a CORS error. So I created ​an argument for the script to specify your custom domain without modifying the source.

Caveat: Umbrel dashboard works, except the page /apps. All your apps are being displayed as 'Starting...' and can not be accessed. They are running though and can be accessed via ip:port in your browser.

SimonHaas avatar Nov 06 '21 12:11 SimonHaas

Just a small note, https://github.com/getumbrel/umbrel/pull/708 is also related to CORS and is touching same lines.

eddy-geek avatar Nov 09 '21 14:11 eddy-geek

Sorry for the delay, Simon. And thanks for working on this. The CORS check was updated a while ago and this should be a non-issue. Closing this PR for now and my apologies for the resulting unproductive work.

mayankchhabra avatar Sep 22 '22 20:09 mayankchhabra