umbrel-apps icon indicating copy to clipboard operation
umbrel-apps copied to clipboard

Amato App Submission

Open ziadgit opened this issue 2 years ago • 7 comments

App Submission

App name

Amato Timer

256x256 SVG icon

(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.)

https://svgshare.com/i/wdB.svg

Gallery images

(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.)

1 2 3

I have tested my app on:

ziadgit avatar Aug 17 '23 20:08 ziadgit

Also @ziadgit , Can you add direct link to SVG to the description:

https://svgshare.com/i/wdB.svg

ParthJadhav avatar Sep 25 '23 11:09 ParthJadhav

Looks good to me @nmfretz

ParthJadhav avatar Sep 25 '23 12:09 ParthJadhav

I believe I have addressed all the branding concerns in the UI and the schema and linked to appropriate bitparasol pages. I've also updated the image to reference the specific sha of the latest image. If after testing this is approved I can update the screenshots.

ziadgit avatar Oct 12 '23 01:10 ziadgit

Excellent, thanks for addressing everything @ziadgit. We can help convert screenshots into gallery images for you and also help format your icon svg. I'll post them here soon for your approval and then we can send this to the app store!

FYI, I changed the submitter to "bitparasol" so that it shows up nicely in the UI. Otherwise it ends up looking like this in the app store.

image

When someone clicks the "bitparasol" hyperlink next to "Submitted by" it brings them to this PR showing you as submitter.

nmfretz avatar Oct 17 '23 17:10 nmfretz

Hello, @nmfretz , what's keeping this PR from merging?

unhighghlow avatar May 15 '24 11:05 unhighghlow

Thanks for pinging me here @highghlow.

@ziadgit, I've just reviewed this again. Is Amato Timer a personal project for learning to code and package an app for umbrelOS? I ask becasue a tomato timer is a common tutorial app for programming. If so, we're hesitant to add this to the official app store because there may not be a large incentive for you (or other developers) to keep maintaining the app.

It is awesome that you're building something for umbrelOS. If you're trying to just start out experimenting with a simple app, then there are a couple of other options that might be better at this early stage in Amato Timer's development:

  1. Create a Community App Store: https://github.com/getumbrel/umbrel-community-app-store

    You and other users can add this app store to umbrelOS through the UI. This allows you to distribute and test the app while you continue developing it. It's a good way to gather feedback and improve your app with real user input.

    image
  2. Use the Portainer app on umbrelOS: https://apps.umbrel.com/app/portainer

    Portainer allows you to run any compose file, so you can very quickly set up and test anything through it.

Let me know if either of those options would work for you.

nmfretz avatar Jun 24 '24 05:06 nmfretz

Hi Nathan,

I'd say the plans long term were a bit more ambitious than that. If there was a learning motivation, it was less the technical aspect, and more the approval process I was curious about. Is there a place for a pomodoro app on the store? If so, I'm happy to design and build toward a feature set/level of design robustness where umbrel is happy to bring the app to the official store.

On Sun, Jun 23, 2024 at 10:47 PM Nathan Fretz @.***> wrote:

Thanks for pinging me here @highghlow https://github.com/highghlow.

@ziadgit https://github.com/ziadgit, I've just reviewed this again. Is Amato Timer a personal project for learning to code and package an app for umbrelOS? I ask becasue a tomato timer is a common tutorial app for programming. If so, we're hesitant to add this to the official app store because there may not be a large incentive for you (or other developers) to keep maintaining the app.

It is awesome that you're building something for umbrelOS. If you're trying to just start out experimenting with a simple app, then there are a couple of other options that might be better at this early stage in Amato Timer's development:

Create a Community App Store: https://github.com/getumbrel/umbrel-community-app-store

You and other users can add this app store to umbrelOS through the UI. This allows you to distribute and test the app while you continue developing it. It's a good way to gather feedback and improve your app with real user input. image.png (view on web) https://github.com/getumbrel/umbrel-apps/assets/85373263/f06be24c-ce97-4bb4-a3ca-ff211e41763c 2.

Use the Portainer app on umbrelOS: https://apps.umbrel.com/app/portainer

Portainer allows you to run any compose file, so you can very quickly set up and test anything through it.

Let me know if either of those options would work for you.

— Reply to this email directly, view it on GitHub https://github.com/getumbrel/umbrel-apps/pull/729#issuecomment-2185661060, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB3WWG5PFJ3CXEVJHKFVTZI6XH7AVCNFSM6AAAAAA3USDCSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGY3DCMBWGA . You are receiving this because you were mentioned.Message ID: @.***>

ziadgit avatar Jun 24 '24 08:06 ziadgit

Understood, thanks for that explanation @ziadgit!

If you're comfortable with this, let's do the following:

I see your app is primarily built with a basic HTML structure and minimal custom styling, relying on the browser’s default rendering of HTML elements like <h1> and <button>. Would you consider adding custom styling (through vanilla CSS or a component library or framework) so that it can stand the test of time against other Tomato Timer apps out there even if you move on to other things and end up never updating Amato again?

nmfretz avatar Sep 12 '24 03:09 nmfretz

@ziadgit I am going to close this PR for now, but please reopen when/if you end up working on Amato again.

nmfretz avatar Sep 18 '24 12:09 nmfretz

Hi Nmfretz,

I'm working on the changes, but have been moving the bitparasol domain this week.

ziadgit avatar Sep 18 '24 14:09 ziadgit