umbrel-apps
umbrel-apps copied to clipboard
Bump nolooking v0.4.0-alpha: Send PayJoin and Contribute Inputs
- Send PayJoin support
- Use the PDK at https://crates.io/crates/payjoin to contribute inputs
Question: Do we need to re-state envvars in docker-compose.yml
?
Hey @DanGould. I'm subbing out @nevets963 for review, so please feel free to tag me if/when you start working more on this again.
ok ⚡️
I've updated this PR to draw from the latest release. I believe I've also resolved all of the feedback here:
I used docker pull nolooking:0.4.0-alpha
in order to get the multi-arch digest. I believe this also fixes #359 by replacing the Entrypoint with:
CMD -- --bind-ip=0.0.0.0 --bind-port=4444 --lnd-address=https://$LND_HOST:$LND_GRPC_PORT --lnd-cert-path=$TLS_FILE --lnd-macaroon-path=$MACAROON_FILE --endpoint=http://$APP_HIDDEN_SERVICE --tor-proxy-address=$TOR_PROXY_IP:$TOR_PROXY_PORT
Hi @DanGould, just checking in to see if you are still working on this and want to keep this PR open?
Yes, working on it
Awesome, will keep open. Thanks Dan.
Any progress?
This is still pending: https://github.com/getumbrel/umbrel-apps/issues/359
@DanGould are you okay if I close this old PR for organizational purposes? We can reopen again when you have time to work on it.
Yes, thanks for staying on top of it when I kept pushing it back
Thanks @DanGould! Please ping me whenever you're ready 🤝