Thomas Leitner

Results 261 comments of Thomas Leitner

I have time this weekend, will take a closer look and then decide. New release will also probably be done. Thanks for your patience!

@ashmaroli My thoughts: * The code changes regarding the immutable literals: Do the changes make things actually faster? * Bumping the needed Ruby version to 2.5 is okay. The documentation...

Please make sure that truffleruby runs all tests without problems. In local testing there are still failures.

This problem only occurs at the start of a paragraph, not when there is some text before the quote. I have looked at the code but there is no easy...

@StoneCypher I will include this in the next released, though the expanded version that also handles multi-codepoint entities will have to wait.

You can use the `:formatter` option for this, see https://kramdown.gettalong.org/syntax_highlighter/rouge.html. All you need to do is write a class that respects the interface (see the link) expected the rouge syntax...

I see, thanks for the explanation. The `call_opts` are more for passing information back out to the converter, so this wouldn't help. How would you represent the to-be-highlighted lines in...

Yes, exactly. So in this case I would suggest you write a syntax highlighter that can parse that line representation and then delegate the rest to the rouge syntax highlighter....

@jonsgreen No, I suggested you write a syntax highlighter that *uses* the built-in rouge highlighter to do the highlighting. But the parsing of the highlighting numbers and instantiating the necessary...

Hmm... I have never seen this syntax, so am unsure if this would be a good addition. Furthermore, adding a new syntax would break backwards compatibility, so this would only...