sops icon indicating copy to clipboard operation
sops copied to clipboard

config: support setting age and PGP keys as a strings array

Open johanfleury opened this issue 4 years ago • 3 comments

Resolves #845

johanfleury avatar Apr 05 '21 21:04 johanfleury

Ok, so I’m not a Go expert and I’m not sure this is the best way to implement this.

Unit tests pass locally, but I’d appreciate a review on this before going further.

johanfleury avatar Apr 05 '21 21:04 johanfleury

I don't think this is backwards compatible, right? Functional tests are failing because of that.

autrilla avatar Apr 08 '21 14:04 autrilla

I can’t really tell why the functional tests are failing and when I tried to run them manually (i.e. executing sops with the same args) it seemed to work.

I can work on making them pass, but as I said, I’m not sure this is the correct way to implement this so I’ve not focused on that yet.

johanfleury avatar Apr 08 '21 15:04 johanfleury

Closing since this now has been implemented in #1880. Thanks a lot for your contribution!

felixfontein avatar Aug 06 '25 18:08 felixfontein