sops icon indicating copy to clipboard operation
sops copied to clipboard

Consider using version-based tags for Docker Images in Docker hub

Open tschaible opened this issue 6 years ago • 7 comments

Currently, it appears the only tags pushed to Dockerhub are the latest tag and the git commit sha.

For example, when the newest 3.4.0 image was tagged, it was tagged as

  • latest
  • 14a22d7a7060a0fba06c5dd716898d47728f0fce

It's often useful to have more meaningful tags created that match the actual version. With the latest 3.4.0 release it would preferred that it also be tagged with the version. So the following docker tags.

  • latest
  • 14a22d7a7060a0fba06c5dd716898d47728f0fce
  • 3.4.0

Additionally, it's not to have simplified major/minor tags. So the ideal set of tags would be

  • latest
  • 14a22d7a7060a0fba06c5dd716898d47728f0fce
  • 3.4.0
  • 3.4
  • 3

tschaible avatar Sep 30 '19 19:09 tschaible

I like this idea and it should be easy to add.

We'll get to it when we can, but if someone else want's to work on it you'll find the dockerhub upload code in here: https://github.com/mozilla/sops/blob/master/.circleci/config.yml

ajvb avatar Oct 11 '19 19:10 ajvb

I would like to work on this. Please assign

imskr avatar Oct 20 '19 11:10 imskr

@ajvb should I make changes in https://github.com/mozilla/sops/blob/master/.circleci/config.yml

imskr avatar Oct 21 '19 17:10 imskr

@imskr yep!

ajvb avatar Oct 21 '19 18:10 ajvb

@ajvb / @imskr - I threw an updated circle config in #607 matching the needs of this issue. I noted some options in the PR description. Happy to tweak it further, but I noticed you are using tags in this repo and that seemed the easiest way to get at version to use in docker push.

eddiewebb avatar Jan 16 '20 15:01 eddiewebb

Fixed with #607

ajvb avatar Jan 23 '20 20:01 ajvb

I'm interested in working on this issue. Could you provide more context about what you're looking for? Any additional details about requirements or constraints would be helpful.

tysoncung avatar Oct 09 '25 02:10 tysoncung