sops icon indicating copy to clipboard operation
sops copied to clipboard

Allow SOPS to use custom AWS KMS and STS Endpoint

Open anandavj opened this issue 1 year ago • 3 comments

There's case when I have custom endpoint for my AWS service, with this changes I could specify STS and KMS endpoint for my AWS service Example usage:

creation_rules:
  - kms: "kms-arn"
    aws_profile: "default"
    aws_kms_endpoint: "https://kms.us-west-1.customawsendpoint.com"
    aws_sts_endpoint: "https://sts.us-west-1.customawsendpoint.com"

anandavj avatar Nov 19 '24 15:11 anandavj

Thanks for your contribution! I can't really comment on the AWS specific things, but as a general note, it looks like you should use gofmt to reformat the changes you made.

Thanks for the note, I've ran gofmt and it should be good now

anandavj avatar Dec 01 '24 18:12 anandavj

I apologize forgot to run the test after merging with main, I've fix the protobuf and finish test it in my local @felixfontein Screenshot 2024-12-14 212146

anandavj avatar Dec 14 '24 14:12 anandavj

You have quite a few commits in this PR that do not belong there. Could you please rebase your PR (instead of adding more merge commits) to get rid of the superfluous commits? Thanks.

felixfontein avatar Dec 23 '24 10:12 felixfontein