sops icon indicating copy to clipboard operation
sops copied to clipboard

Sort masterkeys to try offline decrypt methods first

Open bkreitch opened this issue 2 years ago β€’ 1 comments

This is to address #305. Sort master keys so PGP/age keys appear before the others and being used first.

bkreitch avatar Sep 03 '22 17:09 bkreitch

@ajvb Hi, sorry to bother you, but could you maybe take a look please? Hopefully it's a quick win :)

bkreitch avatar Sep 08 '22 09:09 bkreitch

This is a sensible change, I think. It would be great if you could rebase your work and sign-off your commit. Thanks! :bow:

hiddeco avatar Jul 03 '23 20:07 hiddeco

@hiddeco Ok, rebased and signed-off. Great to see that the project is back to life! πŸŽ‰

bkreitch avatar Jul 04 '23 14:07 bkreitch

I have to check this against the history from the issue, which is why I moved it one milestone further.

But do know it’s on the (now active) backlog. πŸ’

hiddeco avatar Jul 04 '23 15:07 hiddeco

https://github.com/getsops/sops/issues/305#issuecomment-1793766331 might be preferable to this solution, since it is more flexible.

felixfontein avatar Nov 05 '23 15:11 felixfontein

#305 (comment) might be preferable to this solution, since it is more flexible.

@felixfontein Hi, I've opened #1345 which supports comma-separated --decryption-order to replace this PR. (or I can push the new code into this PR if it's more convenient)

bkreitch avatar Nov 08 '23 09:11 bkreitch