packages icon indicating copy to clipboard operation
packages copied to clipboard

mate-user-admin: Update config and add monitoring.yml

Open Staudey opened this issue 1 year ago • 4 comments

Summary

The project has changed their config structure to differentiate between admin users and regular users. See this commit

Additionally some of the user groups were no longer up-to-date with our accountsservice config.

Simply remove the mate-user-admin-specific config, so it grabs the defaults from accountsservice. This way we don't have to update this file when changes to our defaults happen.

Test Plan

  • Created new admin and standard users and observed that there were no more error messages
  • Confirmed users were in the correct groups

Checklist

  • [x] Package was built and tested against unstable

Staudey avatar May 07 '24 12:05 Staudey

Just so I understand what this update is changing:

  • The old config did not differentiate between "admin" and "standard" users when creating them.
  • The new config does: lightdm is now admin-only, sshd added to standard, etc.
  • Existing users are unaffected, this is only for creation of new users

Anything I missed?

davidjharder avatar May 07 '24 13:05 davidjharder

You know what, I just thought of something better. Gonna explain further details when I update this.

Staudey avatar May 07 '24 14:05 Staudey

  • The old config did not differentiate between "admin" and "standard" users when creating them.

Yes. Or rather it had no way to have different group configs between admin and standard users. By chance our config kinda continued working correctly because it just ignored the now invalid value and simply imported from accountsservice. I've now adjusted the patch so the group config is completely removed instead. This means it will always use our central defaults in the accountsservice package and we don't have to adjust this package-specific config when those defaults change.

  • The new config does: lightdm is now admin-only, sshd added to standard, etc.

This was just the change to the upstream defaults, we had (and have) different group configs here

  • Existing users are unaffected, this is only for creation of new users

Yes, this only applies when you create new users within the mate-user-admin app

Staudey avatar May 07 '24 14:05 Staudey

Hey @joebonrichie does this look sane?

davidjharder avatar May 07 '24 19:05 davidjharder