swiftui-pipify icon indicating copy to clipboard operation
swiftui-pipify copied to clipboard

Size classes

Open jordibruin opened this issue 1 year ago • 2 comments

Maybe we should return if the pip window is small, medium or large instead of just the value? Since it will depend on the ratio compared to the screen, and that will change based on how large the view etc is.

jordibruin avatar Jul 03 '22 22:07 jordibruin

Sounds like an interesting idea!

I'm curious on the math that you're proposing here though because in my testing there doesn't always seem to be 3 different sizes that it can even scale to. In fact, I've had it on my phone where you can't change the size (so is that the smallest or largest? it's both 😂).

This is also technically something clients can implement themselves if they have custom business logic by extending the DockableController.

Sherlouk avatar Jul 04 '22 09:07 Sherlouk

Maybe we could pass the frame of the view through to the dockableController and based on that we can determine the relative size?

jordibruin avatar Jul 04 '22 10:07 jordibruin