symbolicator icon indicating copy to clipboard operation
symbolicator copied to clipboard

Support source-context resolution from multiple files

Open vaind opened this issue 2 years ago • 3 comments
trafficstars

Historically, only source-bundles contained sources for source-context. Nowadays, you can also have them in Portable PDBs, whether as embedded, or as links. In the future, other formats may follow.

In order to resolve source context as best as we can, we should not limit resolution to a single debug file that reports has_sources() = true but instead try to match each of them until a match is found. Alternatively, they should be combined. This resolution could be cached if needed.

vaind avatar Mar 22 '23 16:03 vaind

This came up in https://github.com/getsentry/sentry/issues/60236

We'd need to change how the candidates are looked up. Doesn't seem so hard to do but maybe I'm missing something:

https://github.com/getsentry/symbolicator/blob/2474a74225d1b8488d909e0441c1996c0078b6af/crates/symbolicator-native/src/symbolication/module_lookup.rs#L312-L333

Notably from objects.find() docs: " /// Fetches matching objects and returns the metadata of the most suitable object." - it returns a single object.

vaind avatar Nov 13 '24 08:11 vaind

@vaind Would you please help create a PR to implement this enhancement?

zhuxb711 avatar Apr 09 '25 07:04 zhuxb711

@vaind Would you please help create a PR to implement this enhancement?

Hey, I'm afraid I don't have the capacity to create a PR at the moment. In case you'd like to contribute a PR for this feature, though, I can help out with a review.

vaind avatar Apr 09 '25 14:04 vaind