symbolic icon indicating copy to clipboard operation
symbolic copied to clipboard

feat(cabi): Add function to load SourceMapCache from disk

Open loewenheim opened this issue 2 years ago • 3 comments

This also implements AsSelf for SourceMapCache and consequently removes the Inner and OwnedSourceMapCache types from CABI.

loewenheim avatar Sep 26 '22 11:09 loewenheim

Codecov Report

Merging #691 (f50815c) into master (48c3195) will increase coverage by 0.01%. The diff coverage is 0.00%.

:exclamation: Current head f50815c differs from pull request most recent head ecbd97b. Consider uploading reports for the commit ecbd97b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   73.07%   73.08%   +0.01%     
==========================================
  Files          91       91              
  Lines       18313    18311       -2     
==========================================
+ Hits        13382    13383       +1     
+ Misses       4931     4928       -3     

codecov-commenter avatar Sep 26 '22 11:09 codecov-commenter

lgtm, however symbolic_sourcemapcache_from_bytes is still constructing this completely in memory

Right, good point. Where do we want to save the cache? Do we create a temporary file?

loewenheim avatar Sep 26 '22 11:09 loewenheim

I think you can just give it a path from the python side, python should have some named tempfile utilities.

Swatinem avatar Sep 26 '22 12:09 Swatinem