ref: Add a new object type for il2cpp

Open Swatinem opened this issue 3 years ago • 4 comments

I just noticed I forgot to push this change, as I thought it would be part of sentry-cli, but it actually lives in symbolic. That said, the enum is not extensible right now, and it might be worth handling these things in sentry-cli rather than symbolic, as we only want to add this so the sentry-cli output tells us what the purpose/type of the uploaded file is, nothing more nothing less.

Jun 15 '22 15:06 Swatinem

Codecov Report

Merging #598 (abead0b) into master (9b26fc8) will decrease coverage by 0.19%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   67.97%   67.77%   -0.20%     
==========================================
  Files         102      102              
  Lines       19161    19212      +51     
==========================================
- Hits        13024    13021       -3     
- Misses       6137     6191      +54

Jun 15 '22 15:06 codecov-commenter

Oh shit, wrong button, sorry 😅

Jun 17 '22 13:06 kamilogorek

Didn’t I open this as a draft? I’m not convinced this is the way forward, as the only place this is effectively used is when printing things in sentry-cli. Can we come up with a better solution for that maybe instead of touching this type? :-D

Jun 20 '22 08:06 Swatinem

Didn’t I open this as a draft?

👀

Jun 20 '22 08:06 kamilogorek