spotlight icon indicating copy to clipboard operation
spotlight copied to clipboard

feat: Modernize the build

Open dcramer opened this issue 7 months ago • 3 comments

  • Swap to Biome
  • Add Turbo
  • Add initial LLMs guidelines

dcramer avatar May 29 '25 20:05 dcramer

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ❌ Failed (Inspect) Jun 2, 2025 8:03pm

vercel[bot] avatar May 29 '25 20:05 vercel[bot]

I have a few obvious followups from here:

  1. probably need default build/etc to ignore non-packages (e.g. demos)
  2. it'd be valuable to break out the sentry integration into its own package - will just clean up some deps in there and promotes what we want

dcramer avatar May 29 '25 20:05 dcramer

Oh one other learning I had recently: tsup (or tsdown now) is a lot easier for a lot of bundling. Might be worth adopting that as well.

dcramer avatar May 29 '25 20:05 dcramer

Codecov Report

Attention: Patch coverage is 76.47059% with 28 lines in your changes missing coverage. Please review.

Project coverage is 34.12%. Comparing base (99bd7dc) to head (be2226a). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...egrations/sentry/components/events/error/Frame.tsx 50.00% 5 Missing :warning:
...egrations/sentry/components/events/error/Error.tsx 0.00% 4 Missing :warning:
...ntegrations/sentry/components/insights/Queries.tsx 63.63% 4 Missing :warning:
...s/traces/TraceDetails/components/TraceTreeview.tsx 0.00% 3 Missing :warning:
...rc/integrations/sentry/store/slices/sharedSlice.ts 66.66% 3 Missing :warning:
.../integrations/sentry/components/shared/Resizer.tsx 33.33% 2 Missing :warning:
.../src/integrations/sentry/hooks/useMouseTracking.ts 33.33% 2 Missing :warning:
...ges/overlay/src/integrations/sentry/utils/bytes.ts 0.00% 2 Missing :warning:
...components/insights/webVitals/PerformanceChart.tsx 0.00% 1 Missing :warning:
...c/integrations/sentry/data/sentryEventsContext.tsx 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   34.13%   34.12%   -0.01%     
==========================================
  Files         107      107              
  Lines        7078     7083       +5     
  Branches      124      125       +1     
==========================================
+ Hits         2416     2417       +1     
- Misses       4662     4666       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 02 '25 16:06 codecov[bot]

Common footgun in Turbo: have to define the env variables that the build requires. There's some implicit ones it gives you, but thats why the fossilize build was failing.

dcramer avatar Jun 02 '25 17:06 dcramer