spotlight icon indicating copy to clipboard operation
spotlight copied to clipboard

feat(overlay): Quick filters on Trace List

Open Shubhdeep12 opened this issue 7 months ago • 6 comments

Before opening this PR:

  • [x] I added a Changeset Entry with pnpm changeset:add
  • [x] I referenced issues that this PR addresses

#779

https://github.com/user-attachments/assets/bcd289ab-6add-4b58-b8d7-0b93d0fa47c3

  • Added a new useTraceFiltering hook that categorises and applies filters across multiple dimensions based on Traces data.
  • Added TraceListFilter and FilterDropdown components to enable multi-select filtering and searching in the UI.

Shubhdeep12 avatar May 22 '25 06:05 Shubhdeep12

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
spotlightjs ⬜️ Skipped (Inspect) May 29, 2025 0:56am

vercel[bot] avatar May 22 '25 06:05 vercel[bot]

Codecov Report

Attention: Patch coverage is 40.99142% with 619 lines in your changes missing coverage. Please review.

Project coverage is 34.17%. Comparing base (4f3e34a) to head (df8ca2a). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/integrations/sentry/hooks/useTraceFiltering.tsx 38.38% 236 Missing :warning:
...tions/sentry/components/traces/TraceListFilter.tsx 15.07% 107 Missing :warning:
packages/overlay/src/ui/dropdownMenu.tsx 51.29% 94 Missing :warning:
...ations/sentry/components/shared/FilterDropdown.tsx 34.09% 58 Missing :warning:
...ntegrations/sentry/components/traces/TraceList.tsx 12.50% 21 Missing :warning:
...egrations/sentry/components/insights/Resources.tsx 9.52% 19 Missing :warning:
packages/overlay/src/utils/dom.ts 5.26% 18 Missing :warning:
...s/traces/TraceDetails/components/TraceTreeview.tsx 20.00% 16 Missing :warning:
...es/overlay/src/integrations/sentry/utils/traces.ts 27.77% 13 Missing :warning:
packages/overlay/src/ui/input.tsx 45.45% 12 Missing :warning:
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   33.13%   34.17%   +1.04%     
==========================================
  Files         107      107              
  Lines        6160     7078     +918     
  Branches      122      124       +2     
==========================================
+ Hits         2041     2419     +378     
- Misses       4119     4659     +540     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 22 '25 06:05 codecov[bot]

I haven’t looked at the code yet, but I can spot shadcn components from a mile away 😆. I would have used them too; great foundations and they let us ship so quickly. I’ll take a look at this soon! thanks 🙇

betegon avatar May 23 '25 11:05 betegon

yeah @betegon, Shadcn components really is a cheat code to ship fast 😆 thought it is the time to put it to use 💥

Shubhdeep12 avatar May 23 '25 11:05 Shubhdeep12

Let's clarify the time filter thing and we're done. Thanks for your patience @Shubhdeep12

Yes it's right. Time filter is not working as expected. Ideally it should have static values like"Last 1 minute" , "Last 15 minutes" "Last 1 hour", etc. Let me fix this. Thanks

Shubhdeep12 avatar May 28 '25 17:05 Shubhdeep12

hey @betegon can you please check now. thanks

Shubhdeep12 avatar May 29 '25 05:05 Shubhdeep12