snuba
snuba copied to clipboard
fix(api): add quota allowance to clickhouse errors
In https://github.com/getsentry/sentry/pull/96151#discussion_r2231549589, we saw a small issue where for the max byte scanning policies, we didn't return a quota_allowance in the API response since we were overwriting the original error. This manually puts the quota_allowance back on.
:x: 1 Tests Failed:
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 2529 | 1 | 2528 | 11 |
View the top 1 failed test(s) by shortest run time
tests.test_snql_api.TestSnQLApi::test_allocation_policy_max_bytes_to_readStack Traces | 0.401s run time
Traceback (most recent call last): File "/.venv/lib/python3.11........./site-packages/_pytest/runner.py", line 341, in from_call result: TResult | None = func() ^^^^^^ File "/.venv/lib/python3.11........./site-packages/_pytest/runner.py", line 242, in <lambda> lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11....../site-packages/pluggy/_hooks.py", line 513, in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11....../site-packages/pluggy/_manager.py", line 120, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 182, in _multicall return outcome.get_result() ^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11.../site-packages/pluggy/_result.py", line 100, in get_result raise exc.with_traceback(exc.__traceback__) File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File "/.venv/lib/python3.11....../site-packages/_pytest/threadexception.py", line 92, in pytest_runtest_call yield from thread_exception_runtest_hook() File "/.venv/lib/python3.11....../site-packages/_pytest/threadexception.py", line 68, in thread_exception_runtest_hook yield File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File "/.venv/lib/python3.11....../site-packages/_pytest/unraisableexception.py", line 95, in pytest_runtest_call yield from unraisable_exception_runtest_hook() File "/.venv/lib/python3.11....../site-packages/_pytest/unraisableexception.py", line 70, in unraisable_exception_runtest_hook yield File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File "/.venv/lib/python3.11....../site-packages/_pytest/logging.py", line 846, in pytest_runtest_call yield from self._runtest_for(item, "call") File "/.venv/lib/python3.11....../site-packages/_pytest/logging.py", line 829, in _runtest_for yield File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File "/.venv/lib/python3.11.../site-packages/_pytest/capture.py", line 880, in pytest_runtest_call return (yield) ^^^^^ File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File "/.venv/lib/python3.11.../site-packages/_pytest/skipping.py", line 257, in pytest_runtest_call return (yield) ^^^^^ File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 103, in _multicall res = hook_impl.function(*args) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11........./site-packages/_pytest/runner.py", line 174, in pytest_runtest_call item.runtest() File "/.venv/lib/python3.11....../site-packages/_pytest/python.py", line 1627, in runtest self.ihook.pytest_pyfunc_call(pyfuncitem=self) File "/.venv/lib/python3.11....../site-packages/pluggy/_hooks.py", line 513, in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11....../site-packages/pluggy/_manager.py", line 120, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 139, in _multicall raise exception.with_traceback(exception.__traceback__) File "/.venv/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 103, in _multicall res = hook_impl.function(*args) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/.venv/lib/python3.11....../site-packages/_pytest/python.py", line 159, in pytest_pyfunc_call result = testfunction(**testargs) ^^^^^^^^^^^^^^^^^^^^^^^^ File ".../snuba/tests/test_snql_api.py", line 1356, in test_allocation_policy_max_bytes_to_read assert response.status_code == 429 AssertionError: assert 500 == 429 + where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code
To view more test analytics, go to the Test Analytics Dashboard 📋 Got 3 mins? Take this short survey to help us improve Test Analytics.