snuba
snuba copied to clipboard
feat(error_sampling): Populate sample_weight on errors from incoming sample_rate
sample_weight on errors is set as 1/sample_rate, using the sample_rate set on the event data. Set to None if no sample_rate exists.
This PR has a migration; here is the generated SQL for ./snuba/migrations/groups.py
:x: 1 Tests Failed:
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 235 | 1 | 234 | 6 |
View the top 1 failed test(s) by shortest run time
tests.clickhouse.test_native::test_concurrency_limitStack Traces | 0.014s run time
Traceback (most recent call last): File ".../local/lib/python3.11........./site-packages/_pytest/runner.py", line 341, in from_call result: TResult | None = func() ^^^^^^ File ".../local/lib/python3.11........./site-packages/_pytest/runner.py", line 242, in <lambda> lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11....../site-packages/pluggy/_hooks.py", line 513, in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11....../site-packages/pluggy/_manager.py", line 120, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 182, in _multicall return outcome.get_result() ^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11.../site-packages/pluggy/_result.py", line 100, in get_result raise exc.with_traceback(exc.__traceback__) File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File ".../local/lib/python3.11....../site-packages/_pytest/threadexception.py", line 92, in pytest_runtest_call yield from thread_exception_runtest_hook() File ".../local/lib/python3.11....../site-packages/_pytest/threadexception.py", line 68, in thread_exception_runtest_hook yield File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File ".../local/lib/python3.11....../site-packages/_pytest/unraisableexception.py", line 95, in pytest_runtest_call yield from unraisable_exception_runtest_hook() File ".../local/lib/python3.11....../site-packages/_pytest/unraisableexception.py", line 70, in unraisable_exception_runtest_hook yield File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File ".../local/lib/python3.11....../site-packages/_pytest/logging.py", line 846, in pytest_runtest_call yield from self._runtest_for(item, "call") File ".../local/lib/python3.11....../site-packages/_pytest/logging.py", line 829, in _runtest_for yield File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File ".../local/lib/python3.11.../site-packages/_pytest/capture.py", line 880, in pytest_runtest_call return (yield) ^^^^^ File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 167, in _multicall teardown.throw(outcome._exception) File ".../local/lib/python3.11.../site-packages/_pytest/skipping.py", line 257, in pytest_runtest_call return (yield) ^^^^^ File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 103, in _multicall res = hook_impl.function(*args) ^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11........./site-packages/_pytest/runner.py", line 174, in pytest_runtest_call item.runtest() File ".../local/lib/python3.11....../site-packages/_pytest/python.py", line 1627, in runtest self.ihook.pytest_pyfunc_call(pyfuncitem=self) File ".../local/lib/python3.11....../site-packages/pluggy/_hooks.py", line 513, in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11....../site-packages/pluggy/_manager.py", line 120, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 139, in _multicall raise exception.with_traceback(exception.__traceback__) File ".../local/lib/python3.11.........................../site-packages/pluggy/_callers.py", line 103, in _multicall res = hook_impl.function(*args) ^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../local/lib/python3.11....../site-packages/_pytest/python.py", line 159, in pytest_pyfunc_call result = testfunction(**testargs) ^^^^^^^^^^^^^^^^^^^^^^^^ File ".../tests/clickhouse/test_native.py", line 82, in test_concurrency_limit assert connection.execute.call_count == 2, "Expected two attempts" AssertionError: Expected two attempts assert 1 == 2 + where 1 = <Mock name='mock.execute' id='140535408183056'>.call_count + where <Mock name='mock.execute' id='140535408183056'> = <Mock id='140535403811664'>.execute
To view more test analytics, go to the Test Analytics Dashboard 📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@volokluev hey Volo, thanks for the review! I actually had to add some stuff and fix a few tests, would appreciate another review just to make sanity check, thanks