test(spans): add some validation to the test json

[dbanda]

Add some type checking to the spans tests to make sure our test data schemas make sense.

[codecov[bot]]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (982ac34) 90.34% compared to head (521bc63) 90.34%.

:exclamation: Current head 521bc63 differs from pull request most recent head ce3c7cb. Consider uploading reports for the commit ce3c7cb to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4404   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files         803      803           
  Lines       39423    39431    +8     
  Branches      245      245           
=======================================
+ Hits        35615    35623    +8     
  Misses       3776     3776           
  Partials       32       32           

Impacted Files	Coverage Δ
tests/datasets/test_spans_processor.py	97.14% <100.00%> (+0.17%)	:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[lynnagara]

Have you seen https://github.com/getsentry/snuba/blob/ce8470829bc683345695bcd3ef26492757727c14/tests/consumers/test_schemas.py?

It attempts to run all message processors against the example payloads in sentry-kafka-schemas, including spans. Not sure if this overlaps with the intention here, or this targets something different.

[dbanda]

Have you seen https://github.com/getsentry/snuba/blob/ce8470829bc683345695bcd3ef26492757727c14/tests/consumers/test_schemas.py?

It attempts to run all message processors against the example payloads in sentry-kafka-schemas, including spans. Not sure if this overlaps with the intention here, or this targets something different.

Does this require that we put stuff in the examples folder? the only examples we have so far are the ones in this test, but I can craft some if that helps.

[lynnagara]

Does this require that we put stuff in the examples folder? the only examples we have so far are the ones in this test, but I can craft some if that helps.

Yeah it does. If there's an example message that looks different to what's already covered, i think that would be good