sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(grouping): Add log to grouping config upgrade

Open lobsterkatie opened this issue 7 months ago • 2 comments

In theory, we should only hit the branch of update_or_set_grouping_config_if_needed where we're starting with an outdated config and updating it if the project in question has an outdated config. We've long since force-upgraded not only every project on an old config but also every project from an options epoch that would mean it defaults to an old config, so in theory we should no longer be landing in that branch. And yet.

In order to debug how we're still seeing the metric from that branch ping, this adds a log with more specific data (like project id) than what we can gather in DataDog.

(The extra weird thing is, DataDog says the upgrades are upgrades from the legacy config, and yet no no new transition periods have started, which they should have if the existing config is a valid one. Very mysterious.)

lobsterkatie avatar Jun 13 '25 23:06 lobsterkatie

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/grouping/ingest/config.py

Function Unhandled Issue
update_or_set_grouping_config_if_needed [**InvalidCacheKey: Cache key will cause errors if used with memcached: ":2:grouping-config-update:4509479686242304:[{'id': 'legacy:2019-03-12', 'base': None, 'strategies': 'chained-exception:legacy', 'csp:v1', 'expect-ct:v1', 'expect-staple:v1', 'hpkp:v1', 'message:v1', ...** ...
Event Count: 28

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Jun 13 '25 23:06 sentry[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93572   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files       10322    10322           
  Lines      595060   595062    +2     
  Branches    23141    23141           
=======================================
+ Hits       523689   523693    +4     
+ Misses      70878    70876    -2     
  Partials      493      493           

codecov[bot] avatar Jun 13 '25 23:06 codecov[bot]