sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(feedback): frontend to display summary

Open vishnupsatish opened this issue 7 months ago • 2 comments

To be honest I don't know how to implement the "Read more" logic that's on the Figma, image below: image I think I might be able to add the "Read more" on the next line, but I'm wondering that if the response is meant to be only a few sentences, do we need it?

vishnupsatish avatar Jun 13 '25 22:06 vishnupsatish

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

github-actions[bot] avatar Jun 13 '25 22:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93567       +/-   ##
===========================================
- Coverage   88.04%   87.10%    -0.94%     
===========================================
  Files       10337     5593     -4744     
  Lines      596922   453549   -143373     
  Branches    23196        0    -23196     
===========================================
- Hits       525534   395061   -130473     
+ Misses      70929    58488    -12441     
+ Partials      459        0      -459     

codecov[bot] avatar Jun 13 '25 22:06 codecov[bot]

I'm wondering that if the response is meant to be only a few sentences, do we need it?

great point! I think in most cases we won't, but maybe the read more is meant as a "fallback" so the summary component stays within a max height - which you can set either as a raw number of pixels, or % of screen height.

aliu39 avatar Jun 16 '25 20:06 aliu39

Jesse mentioned he'll get a design out for this with updated states for loading and if there aren't enough feedbacks. Should we merge and experiment with this for now, and make those changes in a follow-up PR? Or wait to incorporate those changes here.

vishnupsatish avatar Jun 17 '25 17:06 vishnupsatish

Jesse mentioned he'll get a design out for this with updated states for loading and if there aren't enough feedbacks. Should we merge and experiment with this for now, and make those changes in a follow-up PR? Or wait to incorporate those changes here.

i think it's fine to merge what we're happy with here & make changes in a followup PR

michellewzhang avatar Jun 17 '25 17:06 michellewzhang

hmm, maybe the error you're seeing is similar to the one Ryan was seeing? like the LLM not generating in the right format. I'm investigating now

Edit: looking at Sentry, it does seem that you were facing the same parsing error that Ryan encountered (I am encountering this too)

vishnupsatish avatar Jun 17 '25 21:06 vishnupsatish