sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(browser reporting): Use option to control `Reporting-Endpoints` header

Open lobsterkatie opened this issue 7 months ago • 1 comments

This switches our check for whether to add the Reporting-Endpoints header from using staff.is_active (which seems to be false even if the user has is_staff = True in the database) to using a new option, issues.browser_reporting.reporting_endpoints_header_enabled.

lobsterkatie avatar Jun 13 '25 21:06 lobsterkatie

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93560       +/-   ##
===========================================
+ Coverage   46.30%   88.00%   +41.69%     
===========================================
  Files       10306    10322       +16     
  Lines      594236   594964      +728     
  Branches    23141    23141               
===========================================
+ Hits       275175   523608   +248433     
+ Misses     318568    70863   -247705     
  Partials      493      493               

codecov[bot] avatar Jun 13 '25 21:06 codecov[bot]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RuntimeError: Database access not allowed, use the "django_db" mark, or the "db" or "transactional_db" fixtures to enable it. pytest.runtest.protocol tests/sentry/api/endpoi... View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Jun 16 '25 13:06 sentry[bot]

reverting: this is breaking CI

asottile-sentry avatar Jun 16 '25 15:06 asottile-sentry

PR reverted: c57c01347cefc08387d8e9f3476f23eb0876bd67

getsentry-bot avatar Jun 16 '25 15:06 getsentry-bot