ref(deletions): Remove unnecessary calls in endpoint
During the API call we were doing work that the Group model already does.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #93541 +/- ##
==========================================
- Coverage 87.83% 87.81% -0.02%
==========================================
Files 10478 10492 +14
Lines 605960 606303 +343
Branches 23674 23674
==========================================
+ Hits 532216 532403 +187
- Misses 73380 73536 +156
Partials 364 364
Bug: Group Deletion Logic Inconsistency
The
GroupHashdeletion was removed from thedelete_group_listAPI endpoint, despite PR discussion acknowledging the need to restore it. This allows new events to associate with groups marked asPENDING_DELETIONduring the window before the asynchronous deletion task completes. This contradicts the original intent to prevent such associations and is inconsistent with the retainedGroupInboxdeletion logic.
src/sentry/api/helpers/group_index/delete.py#L78-L84Fix in Cursor • Fix in WebWas this report helpful? Give feedback by reacting with 👍 or 👎
We don't want to delete GroupHash since it will be needed during the task execution to call Seer.