sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(deletions): Remove unnecessary calls in endpoint

Open armenzg opened this issue 6 months ago • 1 comments

During the API call we were doing work that the Group model already does.

armenzg avatar Jun 13 '25 18:06 armenzg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93541      +/-   ##
==========================================
- Coverage   87.83%   87.81%   -0.02%     
==========================================
  Files       10478    10492      +14     
  Lines      605960   606303     +343     
  Branches    23674    23674              
==========================================
+ Hits       532216   532403     +187     
- Misses      73380    73536     +156     
  Partials      364      364              

codecov[bot] avatar Jun 13 '25 19:06 codecov[bot]

Bug: Group Deletion Logic Inconsistency

The GroupHash deletion was removed from the delete_group_list API endpoint, despite PR discussion acknowledging the need to restore it. This allows new events to associate with groups marked as PENDING_DELETION during the window before the asynchronous deletion task completes. This contradicts the original intent to prevent such associations and is inconsistent with the retained GroupInbox deletion logic.

src/sentry/api/helpers/group_index/delete.py#L78-L84 Fix in CursorFix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

We don't want to delete GroupHash since it will be needed during the task execution to call Seer.

armenzg avatar Jul 14 '25 19:07 armenzg