sentry icon indicating copy to clipboard operation
sentry copied to clipboard

fix(aci): Use filter_recently_fired_workflow_actions exclusively

Open kcons opened this issue 7 months ago • 3 comments

Use WorkflowActionGroupStatus for our recency filtering rather than ActionGroupStatus. While we're at it, remove any remaining active uses of ActionGroupStatus.

kcons avatar Jun 11 '25 22:06 kcons

There's an argument that we should've tracked the differences in outcome and validated that they are what we intend, but given the lack of validated traffic on the old implementation, I'm not sure that's worth waiting for vs just trying to make sure this is correct.

kcons avatar Jun 11 '25 22:06 kcons

Actually, I should probably remove the various lingering uses of ActionGroup first..

kcons avatar Jun 11 '25 22:06 kcons

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93382      +/-   ##
==========================================
+ Coverage   83.38%   88.07%   +4.68%     
==========================================
  Files       10322    10311      -11     
  Lines      595614   594638     -976     
  Branches    23137    22985     -152     
==========================================
+ Hits       496637   523707   +27070     
+ Misses      98484    70499   -27985     
+ Partials      493      432      -61     

codecov[bot] avatar Jun 11 '25 22:06 codecov[bot]