sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Skip flaky test: test_missing_dsym

Open devinfra-flakiness[bot] opened this issue 7 months ago • 1 comments

Please help us keep Sentry flake-free by merging this PR while a longer-term resolution is implemented in issue #93040.


See also: Flaky Test Policy & Responsibilities

devinfra-flakiness[bot] avatar Jun 06 '25 17:06 devinfra-flakiness[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93041      +/-   ##
==========================================
- Coverage   82.87%   81.80%   -1.07%     
==========================================
  Files       10295    10356      +61     
  Lines      590815   595381    +4566     
  Branches    22980    22980              
==========================================
- Hits       489629   487046    -2583     
- Misses      99752   106901    +7149     
  Partials     1434     1434              

codecov[bot] avatar Jun 06 '25 18:06 codecov[bot]

@untitaker Tagging you in this since it looks like you were the last one to touch this test

hubertdeng123 avatar Jun 16 '25 22:06 hubertdeng123

FYI we'd ideally assign these PR's based on codeowners, so if that is more fitting let us know

hubertdeng123 avatar Jun 16 '25 22:06 hubertdeng123

yes please use codeowners for this + linear tickets, this is entirely misrouted

untitaker avatar Jun 17 '25 12:06 untitaker

@untitaker There is no codeowners for this file - that's why I had to manually assign you. I did it with git blame since you're the last one who touched the test. If this is misrouted, who is the best team/person to go to?

hubertdeng123 avatar Jun 17 '25 15:06 hubertdeng123

@hubertdeng123 symbolicator is owned by ingest team (see service registry)

untitaker avatar Jun 17 '25 15:06 untitaker

@untitaker Please help us update codeowners. You'll see similar things in future otherwise.

bukzor avatar Jun 17 '25 17:06 bukzor

well... https://github.com/getsentry/sentry/blob/b040b91c563a9ef702350a6a68d8e5e20959df64/.github/CODEOWNERS#L52

untitaker avatar Jun 17 '25 18:06 untitaker

well...

https://github.com/getsentry/sentry/blob/b040b91c563a9ef702350a6a68d8e5e20959df64/.github/CODEOWNERS#L52

That's very mysterious. Do I misunderstand codeowners entirely? Is it not meant to set the PR reviewers? I'll have to make a followup issue for this...

bukzor avatar Jun 18 '25 16:06 bukzor

i think a line further down probably overwrites it in some way (last rule wins and defines all codeowners)

somehow it doesn't work at all, otherwise github woudl've assigned this PR properly too

untitaker avatar Jun 18 '25 16:06 untitaker

Mystery solved. That line was added quite recently, and isn't there in this PR. So we were both right: that line isn't there (in this PR) but also it's there (in HEAD).

https://github.com/getsentry/sentry/blob/b6ff5daef8ce9518d050d2eabbda0fc151d64470/.github/CODEOWNERS#L50-L52

Thanks @asottile-sentry

bukzor avatar Jun 18 '25 16:06 bukzor