sentry icon indicating copy to clipboard operation
sentry copied to clipboard

chore(sentryapps): better logging and errors for select requester

Open Christinarlong opened this issue 1 year ago • 1 comments

Ok more like let's differentiate between when we fail due to external requests failing or due to validation errors

Christinarlong avatar Oct 18 '24 19:10 Christinarlong

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ps/api/endpoints/installation_external_requests.py 77.77% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #79377       +/-   ##
===========================================
+ Coverage   57.01%   78.35%   +21.33%     
===========================================
  Files        7114     7125       +11     
  Lines      314446   315158      +712     
  Branches    51416    51510       +94     
===========================================
+ Hits       179292   246950    +67658     
+ Misses     130529    61739    -68790     
- Partials     4625     6469     +1844     

codecov[bot] avatar Oct 19 '24 05:10 codecov[bot]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValidationError: Invalid response format for SelectField in id=39357 scope_list=['event:read'] application_id=6569... sentry.api.sentry_app_components.get View Issue
  • ‼️ UnboundLocalError: cannot access local variable 'url' where it is not associated with a value sentry.api.sentry_app_components.get View Issue
  • ‼️ ValidationError: Invalid response format for SelectField in id=81605 scope_list=['event:read', 'event:write', 'org... sentry.api.sentry_app_components.get View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Oct 23 '24 01:10 sentry[bot]