feat(insights): keep transaction summary pages within the domain view
If I navigate to performance -> frontend in the sidebar, then i click a transaction, I end up in the transaction summary page.
This PR updates the header for that page, and ensure all of the following tabs remain within the frontend domain view.
(i.e when clicking on these tabs, the resulting url will still be under /performance/frontend/summary, currently it goes back to /performance/summary)
We have to also do the sub links as well in another PR, but doing this one step at a time.
Codecov Report
Attention: Patch coverage is 31.74603% with 43 lines in your changes missing coverage. Please review.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #79056 +/- ##
==========================================
- Coverage 78.38% 78.33% -0.06%
==========================================
Files 7140 7133 -7
Lines 315440 314125 -1315
Branches 51550 51306 -244
==========================================
- Hits 247261 246069 -1192
+ Misses 61711 61630 -81
+ Partials 6468 6426 -42
Makes sense to me! There's a lot of drilling on
DomainViewprops. I wonder if there's an easy way to reduce that, but turning those url functions into hooks probably involves a lot of cascading updates.
@edwardgou-sentry Yeah, I definitely am not a fan of the drilling down props everywhere. I wanted to use hooks everywhere, I wasn't thinking about the react update side, it was more to do with links that are sometimes generated within a class based component, or within their own helper function, making using hooks impossible or more work (like a wrapper component). There's also many more links to update within the app too.
The performance pages use prop drilling pretty extensively, so i figured it would be best to continue doing it to help get this feature out, make sure everything works as intended, and then go for a refactor to use hooks where it makes sense.