sentry icon indicating copy to clipboard operation
sentry copied to clipboard

fix(dashboards): control legends individually

Open nikkikapadia opened this issue 1 year ago • 2 comments

Previously charts that have the same series on their legend were controlled together (toggling one off would toggle them both off). Now the legend can be controlled individually as they are associated with the widget id. Since it is stored in the query (in the format widgetId-seriesName1-seriesName2-...), this also fixes the issue where selecting a new time range or other filter changes reset what series were selected.

video evidence:

https://github.com/user-attachments/assets/2a61d162-bc08-4129-983e-bfe328a5bcd0

nikkikapadia avatar Oct 07 '24 13:10 nikkikapadia

Codecov Report

Attention: Patch coverage is 63.21839% with 32 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...atic/app/views/dashboards/dashboardLegendUtils.tsx 67.64% 22 Missing :warning:
...dashboards/widgetCard/widgetCardChartContainer.tsx 50.00% 3 Missing :warning:
static/app/views/dashboards/detail.tsx 50.00% 2 Missing :warning:
static/app/views/dashboards/widgetCard/chart.tsx 33.33% 2 Missing :warning:
static/app/components/modals/widgetViewerModal.tsx 0.00% 1 Missing :warning:
...rds/widgetBuilder/buildSteps/visualizationStep.tsx 50.00% 1 Missing :warning:
...p/views/dashboards/widgetBuilder/widgetBuilder.tsx 66.66% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #78675    +/-   ##
========================================
  Coverage   78.27%   78.27%            
========================================
  Files        7120     7127     +7     
  Lines      313496   313764   +268     
  Branches    51171    51221    +50     
========================================
+ Hits       245388   245612   +224     
- Misses      61679    61717    +38     
- Partials     6429     6435     +6     

codecov[bot] avatar Oct 07 '24 13:10 codecov[bot]

Bundle Report

Changes will increase total bundle size by 10.08kB (0.03%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.98MB 10.08kB (0.03%) :arrow_up:

codecov[bot] avatar Oct 11 '24 18:10 codecov[bot]