sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(test-alerts): Adds exception filtering for IntegrationErrors to be shown in the UI:

Open GabeVillalobos opened this issue 1 year ago • 1 comments

  • Adds a new ApiInvalidRequestError type, to better differentiate between 400 and unhandled non-400 responses from downstream APIs.
  • Adds filtering to our ticket creation utils which only propagates IntegrationFormErrors when a known 400 status response is received by requests to an integration's API
  • Adds sentry error IDs to unhandled test notification errors for easier customer triage.

Note: This does not fix the brunt of the IntegrationFormError sentry issues we're getting for Jira, which I'll address in a follow-up PR, but this does give me more confidence to GA the UI error reporting for test notifications.

GabeVillalobos avatar Oct 04 '24 21:10 GabeVillalobos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78653       +/-   ##
===========================================
+ Coverage   64.67%   78.24%   +13.56%     
===========================================
  Files        7100     7105        +5     
  Lines      312820   313067      +247     
  Branches    51092    51121       +29     
===========================================
+ Hits       202331   244960    +42629     
+ Misses     103837    61740    -42097     
+ Partials     6652     6367      -285     

codecov[bot] avatar Oct 04 '24 21:10 codecov[bot]